Comments on: WebObjects 5.3.1 WORedirect Bug

By: Daniel

Daniel — Fri, 10 Feb 2006 15:20:13 +0000

for WOHyperlink, I found the culprit: in com.webobjects.appserver._private.WOURLEncoder.encodeAsCGIFormValues(…) “&” has been replaced with “&” in WO 5.3.1.

By: Daniel

Daniel — Fri, 10 Feb 2006 08:48:57 +0000

Same problem with a WOHyperlink with href binding and parameters (bindings starting with a ?): & instead of & in the generate url.

By: david

david — Tue, 20 Dec 2005 21:44:33 +0000

I don’t think so, I think that WORedirect is just sending the request as is, and it’s confusing WORequest when you ask for formValues().

By: Galen Rhodes

Galen Rhodes — Tue, 20 Dec 2005 21:21:21 +0000

It WORedirect encoding the ampersands a second time so that you wind up with something like &?

By: david

david — Mon, 19 Dec 2005 18:43:48 +0000

I don’t know about that Galen,

Yes the context().directActionURLForActionNamed(…) method is encoding the ampersands. But that would be the correct behaviour if you wanted to embed the URL in your page (ie: use it with a WODynamicElement).

If you click on a URL containing encoded ampersands with a browser, it will decode them before making the request.

I think WORedirect is kind of acting like a browser in this instance and should be decoding the ampersands as well.

Obviously, I didn’t write the code. So I’ll let Apple decide what the correct behavior should be or where the fix should lie.

By: Galen Rhodes

Galen Rhodes — Mon, 19 Dec 2005 18:28:21 +0000

I think we should be clear that the bug is not with WORedirect but rather with WOContext. (or something that WOContext calls)

During the generation of the URL in the call to directActionURLForActionNamed(…) the ampersands (&) are being encoded when the parameters from the dictionary are appended to the URL.

By: Mike Schrag

Mike Schrag — Tue, 15 Nov 2005 22:57:00 +0000

Same thing happened in my app with just generating a direct action URL to put in a javascript redirect … I don’t think it’s your code.